From 09ca1c43889655725da294b991ede77d82f9cc10 Mon Sep 17 00:00:00 2001 From: Pior Bastida Date: Wed, 23 Nov 2016 20:01:48 -0500 Subject: [PATCH] Fix JSON dump error in ecs.update_service with task_definition (#775) --- moto/ecs/models.py | 4 ++-- tests/test_ecs/test_ecs_boto3.py | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/moto/ecs/models.py b/moto/ecs/models.py index 3a2ec13f..65f44c8b 100644 --- a/moto/ecs/models.py +++ b/moto/ecs/models.py @@ -375,8 +375,8 @@ class EC2ContainerServiceBackend(BaseBackend): cluster_service_pair = '{0}:{1}'.format(cluster_name, service_name) if cluster_service_pair in self.services: if task_definition_str is not None: - task_definition = self.fetch_task_definition(task_definition_str) - self.services[cluster_service_pair].task_definition = task_definition + self.fetch_task_definition(task_definition_str) + self.services[cluster_service_pair].task_definition = task_definition_str if desired_count is not None: self.services[cluster_service_pair].desired_count = desired_count return self.services[cluster_service_pair] diff --git a/tests/test_ecs/test_ecs_boto3.py b/tests/test_ecs/test_ecs_boto3.py index 921dea69..271545ef 100644 --- a/tests/test_ecs/test_ecs_boto3.py +++ b/tests/test_ecs/test_ecs_boto3.py @@ -398,6 +398,7 @@ def test_update_service(): response = client.update_service( cluster='test_ecs_cluster', service='test_ecs_service', + taskDefinition='test_ecs_task', desiredCount=0 ) response['service']['desiredCount'].should.equal(0)