From 13252cc4e32a8a903dfcc2def27d698e1b954ad0 Mon Sep 17 00:00:00 2001 From: Miltos Date: Sun, 10 Jan 2021 13:26:40 +0000 Subject: [PATCH] Fix ResourceNotFoundError exception message (#3582) * Fix ResourceNotFoundError message * Fix and update unit test for invalid `describe_identity_pool`. --- moto/cognitoidentity/models.py | 2 +- tests/test_cognitoidentity/test_cognitoidentity.py | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/moto/cognitoidentity/models.py b/moto/cognitoidentity/models.py index ae9f308c..fea7c4ba 100644 --- a/moto/cognitoidentity/models.py +++ b/moto/cognitoidentity/models.py @@ -45,7 +45,7 @@ class CognitoIdentityBackend(BaseBackend): identity_pool = self.identity_pools.get(identity_pool_id, None) if not identity_pool: - raise ResourceNotFoundError(identity_pool) + raise ResourceNotFoundError(identity_pool_id) response = json.dumps( { diff --git a/tests/test_cognitoidentity/test_cognitoidentity.py b/tests/test_cognitoidentity/test_cognitoidentity.py index cfe673cd..159f65f7 100644 --- a/tests/test_cognitoidentity/test_cognitoidentity.py +++ b/tests/test_cognitoidentity/test_cognitoidentity.py @@ -74,13 +74,13 @@ def test_describe_identity_pool(): @mock_cognitoidentity def test_describe_identity_pool_with_invalid_id_raises_error(): conn = boto3.client("cognito-identity", "us-west-2") - with pytest.raises(ClientError) as cm: conn.describe_identity_pool(IdentityPoolId="us-west-2_non-existent") - cm.value.operation_name.should.equal("DescribeIdentityPool") - cm.value.response["Error"]["Code"].should.equal("ResourceNotFoundException") - cm.value.response["ResponseMetadata"]["HTTPStatusCode"].should.equal(400) + cm.value.operation_name.should.equal("DescribeIdentityPool") + cm.value.response["Error"]["Code"].should.equal("ResourceNotFoundException") + cm.value.response["Error"]["Message"].should.equal("us-west-2_non-existent") + cm.value.response["ResponseMetadata"]["HTTPStatusCode"].should.equal(400) # testing a helper function