catalin/moto
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Return error when trying to add rules to a non-existent security group (#3802)

Browse source 
Behavior and error code/message confirmed against real AWS backend.
This commit is contained in:
Brian Pandola 2021-03-26 06:00:51 -07:00 • committed by GitHub
commit 1761be46e3
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 20 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

4
moto/ec2/models.py
View file

@ -2265,6 +2265,8 @@ class SecurityGroupBackend(object):
vpc_id=None,
):
group = self.get_security_group_by_name_or_id(group_name_or_id, vpc_id)
if group is None:
raise InvalidSecurityGroupNotFoundError(group_name_or_id)
if ip_ranges:
if isinstance(ip_ranges, str) or (
six.PY2 and isinstance(ip_ranges, unicode) # noqa
@ -2353,6 +2355,8 @@ class SecurityGroupBackend(object):
):
group = self.get_security_group_by_name_or_id(group_name_or_id, vpc_id)
if group is None:
raise InvalidSecurityGroupNotFoundError(group_name_or_id)
if ip_ranges and not isinstance(ip_ranges, list):
if isinstance(ip_ranges, str) and "CidrIp" not in ip_ranges: