Issue 1770: Deal with the friendly name properly
- Save friendly name in create_secret. - Reference the saved friendly name in responses that have "Name" field. - Verify the received secret_id matches the current value. Don't just test for an empty string. - Add test for mismatched secret_id.
This commit is contained in:
parent
42d486f9b0
commit
1f3256ed40
2 changed files with 13 additions and 3 deletions
|
|
@ -41,12 +41,12 @@ class SecretsManagerBackend(BaseBackend):
|
|||
|
||||
def get_secret_value(self, secret_id, version_id, version_stage):
|
||||
|
||||
if self.secret_id == '':
|
||||
if secret_id not in (self.secret_id, self.name):
|
||||
raise ResourceNotFoundException()
|
||||
|
||||
response = json.dumps({
|
||||
"ARN": secret_arn(self.region, self.secret_id),
|
||||
"Name": self.secret_id,
|
||||
"Name": self.name,
|
||||
"VersionId": "A435958A-D821-4193-B719-B7769357AER4",
|
||||
"SecretString": self.secret_string,
|
||||
"VersionStages": [
|
||||
|
|
@ -61,10 +61,11 @@ class SecretsManagerBackend(BaseBackend):
|
|||
|
||||
self.secret_string = secret_string
|
||||
self.secret_id = name
|
||||
self.name = name
|
||||
|
||||
response = json.dumps({
|
||||
"ARN": secret_arn(self.region, name),
|
||||
"Name": self.secret_id,
|
||||
"Name": self.name,
|
||||
"VersionId": "A435958A-D821-4193-B719-B7769357AER4",
|
||||
})
|
||||
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue