From 3833449b361b232b20ad505867e572abc5f14cdb Mon Sep 17 00:00:00 2001
From: Don Kuntz <dkuntz@journera.com>
Date: Fri, 7 Jun 2019 03:28:10 -0500
Subject: [PATCH] Add batch_create_partition endpoint to Glue client (#2232)

* Add batch_create_partition endpoint to Glue client

* Remove exception as e from glue batch_create_partition, because it's unused
---
 moto/glue/responses.py              | 23 ++++++++++
 tests/test_glue/test_datacatalog.py | 66 +++++++++++++++++++++++++++++
 2 files changed, 89 insertions(+)

diff --git a/moto/glue/responses.py b/moto/glue/responses.py
index 8f09022c..4531b3b5 100644
--- a/moto/glue/responses.py
+++ b/moto/glue/responses.py
@@ -4,6 +4,9 @@ import json
 
 from moto.core.responses import BaseResponse
 from .models import glue_backend
+from .exceptions import (
+    PartitionAlreadyExistsException
+)
 
 
 class GlueResponse(BaseResponse):
@@ -124,6 +127,26 @@ class GlueResponse(BaseResponse):
 
         return ""
 
+    def batch_create_partition(self):
+        database_name = self.parameters.get('DatabaseName')
+        table_name = self.parameters.get('TableName')
+        table = self.glue_backend.get_table(database_name, table_name)
+
+        errors_output = []
+        for part_input in self.parameters.get('PartitionInputList'):
+            try:
+                table.create_partition(part_input)
+            except PartitionAlreadyExistsException:
+                errors_output.append({
+                    'PartitionValues': part_input['Values'],
+                    'ErrorDetail': {
+                        'ErrorCode': 'AlreadyExistsException',
+                        'ErrorMessage': 'Partition already exists.'
+                    }
+                })
+
+        return json.dumps({"Errors": errors_output})
+
     def update_partition(self):
         database_name = self.parameters.get('DatabaseName')
         table_name = self.parameters.get('TableName')
diff --git a/tests/test_glue/test_datacatalog.py b/tests/test_glue/test_datacatalog.py
index e4891f30..237859a3 100644
--- a/tests/test_glue/test_datacatalog.py
+++ b/tests/test_glue/test_datacatalog.py
@@ -310,6 +310,72 @@ def test_get_partition_not_found():
     exc.exception.response['Error']['Code'].should.equal('EntityNotFoundException')
     exc.exception.response['Error']['Message'].should.match('partition')
 
+@mock_glue
+def test_batch_create_partition():
+    client = boto3.client('glue', region_name='us-east-1')
+    database_name = 'myspecialdatabase'
+    table_name = 'myfirsttable'
+    helpers.create_database(client, database_name)
+
+    helpers.create_table(client, database_name, table_name)
+
+    before = datetime.now(pytz.utc)
+
+    partition_inputs = []
+    for i in range(0, 20):
+        values = ["2018-10-{:2}".format(i)]
+        part_input = helpers.create_partition_input(database_name, table_name, values=values)
+        partition_inputs.append(part_input)
+
+    client.batch_create_partition(
+        DatabaseName=database_name,
+        TableName=table_name,
+        PartitionInputList=partition_inputs
+    )
+
+    after = datetime.now(pytz.utc)
+
+    response = client.get_partitions(DatabaseName=database_name, TableName=table_name)
+
+    partitions = response['Partitions']
+
+    partitions.should.have.length_of(20)
+
+    for idx, partition in enumerate(partitions):
+        partition_input = partition_inputs[idx]
+
+        partition['TableName'].should.equal(table_name)
+        partition['StorageDescriptor'].should.equal(partition_input['StorageDescriptor'])
+        partition['Values'].should.equal(partition_input['Values'])
+        partition['CreationTime'].should.be.greater_than(before)
+        partition['CreationTime'].should.be.lower_than(after)
+
+
+@mock_glue
+def test_batch_create_partition_already_exist():
+    client = boto3.client('glue', region_name='us-east-1')
+    database_name = 'myspecialdatabase'
+    table_name = 'myfirsttable'
+    values = ['2018-10-01']
+    helpers.create_database(client, database_name)
+
+    helpers.create_table(client, database_name, table_name)
+
+    helpers.create_partition(client, database_name, table_name, values=values)
+
+    partition_input = helpers.create_partition_input(database_name, table_name, values=values)
+
+    response = client.batch_create_partition(
+        DatabaseName=database_name,
+        TableName=table_name,
+        PartitionInputList=[partition_input]
+    )
+
+    response.should.have.key('Errors')
+    response['Errors'].should.have.length_of(1)
+    response['Errors'][0]['PartitionValues'].should.equal(values)
+    response['Errors'][0]['ErrorDetail']['ErrorCode'].should.equal('AlreadyExistsException')
+
 
 @mock_glue
 def test_get_partition():