catalin/moto
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

[lambda] Add S3 validation for Code["S3Bucket"] and Code["S3Key"].

Browse source 
TODO: validate region.
This commit is contained in:
Hugo Lopes Tavares 2016-02-16 16:43:33 -05:00
commit 482751f731
3 changed files with 80 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

21
moto/awslambda/models.py
View file

@ -6,6 +6,8 @@ import hashlib
import boto.awslambda
from moto.core import BaseBackend
from moto.s3.models import s3_backend
from moto.s3.exceptions import MissingBucket
class LambdaFunction(object):
@ -35,8 +37,23 @@ class LambdaFunction(object):
self.code_size = len(code)
self.code_sha_256 = hashlib.sha256(code).hexdigest()
else:
self.code_size = 123
self.code_sha_256 = 'aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa'
# validate s3 bucket
try:
# FIXME: does not validate bucket region
key = s3_backend.get_key(self.code['S3Bucket'], self.code['S3Key'])
except MissingBucket:
raise ValueError(
"InvalidParameterValueException",
"Error occurred while GetObject. S3 Error Code: NoSuchBucket. S3 Error Message: The specified bucket does not exist")
else:
# validate s3 key
if key is None:
raise ValueError(
"InvalidParameterValueException",
"Error occurred while GetObject. S3 Error Code: NoSuchKey. S3 Error Message: The specified key does not exist.")
else:
self.code_size = 123
self.code_sha_256 = 'aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa'
self.function_arn = 'arn:aws:lambda:123456789012:function:{}'.format(self.function_name)
@property

10
moto/awslambda/responses.py
View file

@ -39,9 +39,13 @@ class LambdaResponse(BaseResponse):
lambda_backend = self.get_lambda_backend(full_url)
spec = json.loads(request.body)
fn = lambda_backend.create_function(spec)
config = fn.get_configuration()
return 201, headers, json.dumps(config)
try:
fn = lambda_backend.create_function(spec)
except ValueError as e:
return 400, headers, json.dumps({"Error": {"Code": e.args[0], "Message": e.args[1]}})
else:
config = fn.get_configuration()
return 201, headers, json.dumps(config)
def _delete_function(self, request, full_url, headers):
lambda_backend = self.get_lambda_backend(full_url)