From 4aff7147b56c2a95cfd499d3c19f50cb349b81a9 Mon Sep 17 00:00:00 2001
From: Anders Kaseorg <andersk@mit.edu>
Date: Wed, 9 Dec 2020 04:25:11 -0800
Subject: [PATCH] test_stepfunctions: Fix failures under non-UTC timezone
 (#3528)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

These tests were passing with TZ=UTC, but under a non-UTC timezone
they were failing:

E       AssertionError: given
E       X = [{'timestamp': datetime.datetime(2020, 1, 1, 0, 0, tzinfo=tzutc()), …}, …]
E           and
E       Y = [{'timestamp': datetime.datetime(2020, 1, 1, 0, 0, tzinfo=tzlocal()), …}, …]
E       X[0]['timestamp'] != Y[0]['timestamp']

With this fix, they pass either way.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
---
 tests/test_stepfunctions/test_stepfunctions.py | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/tests/test_stepfunctions/test_stepfunctions.py b/tests/test_stepfunctions/test_stepfunctions.py
index 16fd9cb5..b0fad76f 100644
--- a/tests/test_stepfunctions/test_stepfunctions.py
+++ b/tests/test_stepfunctions/test_stepfunctions.py
@@ -6,7 +6,7 @@ import os
 import sure  # noqa
 import sys
 from datetime import datetime
-from dateutil.tz import tzlocal
+from dateutil.tz import tzutc
 from botocore.exceptions import ClientError
 import pytest
 
@@ -870,7 +870,7 @@ def test_state_machine_get_execution_history_throws_error_with_unknown_execution
 def test_state_machine_get_execution_history_contains_expected_success_events_when_started():
     expected_events = [
         {
-            "timestamp": datetime(2020, 1, 1, 0, 0, 0, tzinfo=tzlocal()),
+            "timestamp": datetime(2020, 1, 1, 0, 0, 0, tzinfo=tzutc()),
             "type": "ExecutionStarted",
             "id": 1,
             "previousEventId": 0,
@@ -881,7 +881,7 @@ def test_state_machine_get_execution_history_contains_expected_success_events_wh
             },
         },
         {
-            "timestamp": datetime(2020, 1, 1, 0, 0, 10, tzinfo=tzlocal()),
+            "timestamp": datetime(2020, 1, 1, 0, 0, 10, tzinfo=tzutc()),
             "type": "PassStateEntered",
             "id": 2,
             "previousEventId": 0,
@@ -892,7 +892,7 @@ def test_state_machine_get_execution_history_contains_expected_success_events_wh
             },
         },
         {
-            "timestamp": datetime(2020, 1, 1, 0, 0, 10, tzinfo=tzlocal()),
+            "timestamp": datetime(2020, 1, 1, 0, 0, 10, tzinfo=tzutc()),
             "type": "PassStateExited",
             "id": 3,
             "previousEventId": 2,
@@ -903,7 +903,7 @@ def test_state_machine_get_execution_history_contains_expected_success_events_wh
             },
         },
         {
-            "timestamp": datetime(2020, 1, 1, 0, 0, 20, tzinfo=tzlocal()),
+            "timestamp": datetime(2020, 1, 1, 0, 0, 20, tzinfo=tzutc()),
             "type": "ExecutionSucceeded",
             "id": 4,
             "previousEventId": 3,
@@ -936,7 +936,7 @@ def test_state_machine_get_execution_history_contains_expected_failure_events_wh
         raise SkipTest("Cant pass environment variable in server mode")
     expected_events = [
         {
-            "timestamp": datetime(2020, 1, 1, 0, 0, 0, tzinfo=tzlocal()),
+            "timestamp": datetime(2020, 1, 1, 0, 0, 0, tzinfo=tzutc()),
             "type": "ExecutionStarted",
             "id": 1,
             "previousEventId": 0,
@@ -947,7 +947,7 @@ def test_state_machine_get_execution_history_contains_expected_failure_events_wh
             },
         },
         {
-            "timestamp": datetime(2020, 1, 1, 0, 0, 10, tzinfo=tzlocal()),
+            "timestamp": datetime(2020, 1, 1, 0, 0, 10, tzinfo=tzutc()),
             "type": "FailStateEntered",
             "id": 2,
             "previousEventId": 0,
@@ -958,7 +958,7 @@ def test_state_machine_get_execution_history_contains_expected_failure_events_wh
             },
         },
         {
-            "timestamp": datetime(2020, 1, 1, 0, 0, 10, tzinfo=tzlocal()),
+            "timestamp": datetime(2020, 1, 1, 0, 0, 10, tzinfo=tzutc()),
             "type": "ExecutionFailed",
             "id": 3,
             "previousEventId": 2,