catalin/moto
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Merge pull request #1699 from chezclem/ECR-list-images-exception

Browse source 
ECR: list_images should return RepositoryNotFoundException when repository is not found
This commit is contained in:
Steve Pulec 2018-07-19 09:43:29 -04:00 • committed by GitHub
commit 4c904e19c1
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 39 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

23
moto/ecr/models.py
View file

@ -200,17 +200,22 @@ class ECRBackend(BaseBackend):
"""
maxResults and filtering not implemented
"""
images = []
for repository in self.repositories.values():
if repository_name:
if repository.name != repository_name:
continue
repository = None
found = False
if repository_name in self.repositories:
repository = self.repositories[repository_name]
if registry_id:
if repository.registry_id != registry_id:
continue
if repository.registry_id == registry_id:
found = True
else:
found = True
for image in repository.images:
images.append(image)
if not found:
raise RepositoryNotFoundException(repository_name, registry_id or DEFAULT_REGISTRY_ID)
images = []
for image in repository.images:
images.append(image)
return images
def describe_images(self, repository_name, registry_id=None, image_ids=None):