DataSync: Task metadata and update_task

Travis: Moved lint check before build
Datasync: Added delete_task and delete_location

moto/datasync/responses.py

@@ -2,7 +2,6 @@ import json
 
 from moto.core.responses import BaseResponse
 
-from .exceptions import InvalidRequestException
 from .models import datasync_backends
 
 
@@ -18,17 +17,7 @@ class DataSyncResponse(BaseResponse):
         return json.dumps({"Locations": locations})
 
     def _get_location(self, location_arn, typ):
-        location_arn = self._get_param("LocationArn")
-        if location_arn not in self.datasync_backend.locations:
-            raise InvalidRequestException(
-                "Location {0} is not found.".format(location_arn)
-            )
-        location = self.datasync_backend.locations[location_arn]
-        if location.typ != typ:
-            raise InvalidRequestException(
-                "Invalid Location type: {0}".format(location.typ)
-            )
-        return location
+        return self.datasync_backend._get_location(location_arn, typ)
 
     def create_location_s3(self):
         # s3://bucket_name/folder/
@@ -86,16 +75,40 @@ class DataSyncResponse(BaseResponse):
             }
         )
 
+    def delete_location(self):
+        location_arn = self._get_param("LocationArn")
+        self.datasync_backend.delete_location(location_arn)
+        return json.dumps({})
+
     def create_task(self):
         destination_location_arn = self._get_param("DestinationLocationArn")
         source_location_arn = self._get_param("SourceLocationArn")
         name = self._get_param("Name")
-
+        metadata = {
+            "CloudWatchLogGroupArn": self._get_param("CloudWatchLogGroupArn"),
+            "Options": self._get_param("Options"),
+            "Excludes": self._get_param("Excludes"),
+            "Tags": self._get_param("Tags"),
+        }
         arn = self.datasync_backend.create_task(
-            source_location_arn, destination_location_arn, name
+            source_location_arn, destination_location_arn, name, metadata=metadata
         )
         return json.dumps({"TaskArn": arn})
 
+    def update_task(self):
+        task_arn = self._get_param("TaskArn")
+        self.datasync_backend.update_task(
+            task_arn,
+            name=self._get_param("Name"),
+            metadata={
+                "CloudWatchLogGroupArn": self._get_param("CloudWatchLogGroupArn"),
+                "Options": self._get_param("Options"),
+                "Excludes": self._get_param("Excludes"),
+                "Tags": self._get_param("Tags"),
+            },
+        )
+        return json.dumps({})
+
     def list_tasks(self):
         tasks = list()
         for arn, task in self.datasync_backend.tasks.items():
@@ -104,29 +117,32 @@ class DataSyncResponse(BaseResponse):
             )
         return json.dumps({"Tasks": tasks})
 
+    def delete_task(self):
+        task_arn = self._get_param("TaskArn")
+        self.datasync_backend.delete_task(task_arn)
+        return json.dumps({})
+
     def describe_task(self):
         task_arn = self._get_param("TaskArn")
-        if task_arn in self.datasync_backend.tasks:
-            task = self.datasync_backend.tasks[task_arn]
-            return json.dumps(
-                {
-                    "TaskArn": task.arn,
-                    "Name": task.name,
-                    "CurrentTaskExecutionArn": task.current_task_execution_arn,
-                    "Status": task.status,
-                    "SourceLocationArn": task.source_location_arn,
-                    "DestinationLocationArn": task.destination_location_arn,
-                }
-            )
-        raise InvalidRequestException
+        task = self.datasync_backend._get_task(task_arn)
+        return json.dumps(
+            {
+                "TaskArn": task.arn,
+                "Status": task.status,
+                "Name": task.name,
+                "CurrentTaskExecutionArn": task.current_task_execution_arn,
+                "SourceLocationArn": task.source_location_arn,
+                "DestinationLocationArn": task.destination_location_arn,
+                "CloudWatchLogGroupArn": task.metadata["CloudWatchLogGroupArn"],
+                "Options": task.metadata["Options"],
+                "Excludes": task.metadata["Excludes"],
+            }
+        )
 
     def start_task_execution(self):
         task_arn = self._get_param("TaskArn")
-        if task_arn in self.datasync_backend.tasks:
-            arn = self.datasync_backend.start_task_execution(task_arn)
-            if arn:
-                return json.dumps({"TaskExecutionArn": arn})
-        raise InvalidRequestException("Invalid request.")
+        arn = self.datasync_backend.start_task_execution(task_arn)
+        return json.dumps({"TaskExecutionArn": arn})
 
     def cancel_task_execution(self):
         task_execution_arn = self._get_param("TaskExecutionArn")
@@ -135,21 +151,12 @@ class DataSyncResponse(BaseResponse):
 
     def describe_task_execution(self):
         task_execution_arn = self._get_param("TaskExecutionArn")
-
-        if task_execution_arn in self.datasync_backend.task_executions:
-            task_execution = self.datasync_backend.task_executions[task_execution_arn]
-            if task_execution:
-                result = json.dumps(
-                    {
-                        "TaskExecutionArn": task_execution.arn,
-                        "Status": task_execution.status,
-                    }
-                )
-                if task_execution.status == "SUCCESS":
-                    self.datasync_backend.tasks[
-                        task_execution.task_arn
-                    ].status = "AVAILABLE"
-                # Simulate task being executed
-                task_execution.iterate_status()
-                return result
-        raise InvalidRequestException
+        task_execution = self.datasync_backend._get_task_execution(task_execution_arn)
+        result = json.dumps(
+            {"TaskExecutionArn": task_execution.arn, "Status": task_execution.status,}
+        )
+        if task_execution.status == "SUCCESS":
+            self.datasync_backend.tasks[task_execution.task_arn].status = "AVAILABLE"
+        # Simulate task being executed
+        task_execution.iterate_status()
+        return result