catalin/moto
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Merge pull request #2447 from bblommers/bugfix/2445

Browse source 
#2445 - DynamoDB - Add validation for AttributeDefinitions
This commit is contained in:
Mike Grima 2019-10-03 11:52:29 -07:00 • committed by GitHub
commit 60183b29c1
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 61 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

38
tests/test_dynamodb2/test_dynamodb.py
View file

@ -1676,15 +1676,7 @@ def test_query_global_secondary_index_when_created_via_update_table_resource():
{
'AttributeName': 'user_id',
'AttributeType': 'N',
},
{
'AttributeName': 'forum_name',
'AttributeType': 'S'
},
{
'AttributeName': 'subject',
'AttributeType': 'S'
},
}
],
ProvisionedThroughput={
'ReadCapacityUnits': 5,
@ -2258,6 +2250,34 @@ def test_batch_items_should_throw_exception_for_duplicate_request():
ex.exception.response['Error']['Message'].should.equal('Provided list of item keys contains duplicates')
@mock_dynamodb2
def test_index_with_unknown_attributes_should_fail():
dynamodb = boto3.client('dynamodb', region_name='us-east-1')
expected_exception = 'Some index key attributes are not defined in AttributeDefinitions.'
with assert_raises(ClientError) as ex:
dynamodb.create_table(
AttributeDefinitions=[
{'AttributeName': 'customer_nr', 'AttributeType': 'S'},
{'AttributeName': 'last_name', 'AttributeType': 'S'}],
TableName='table_with_missing_attribute_definitions',
KeySchema=[
{'AttributeName': 'customer_nr', 'KeyType': 'HASH'},
{'AttributeName': 'last_name', 'KeyType': 'RANGE'}],
LocalSecondaryIndexes=[{
'IndexName': 'indexthataddsanadditionalattribute',
'KeySchema': [
{'AttributeName': 'customer_nr', 'KeyType': 'HASH'},
{'AttributeName': 'postcode', 'KeyType': 'RANGE'}],
'Projection': { 'ProjectionType': 'ALL' }
}],
BillingMode='PAY_PER_REQUEST')
ex.exception.response['Error']['Code'].should.equal('ValidationException')
ex.exception.response['Error']['Message'].should.contain(expected_exception)
def _create_user_table():
client = boto3.client('dynamodb', region_name='us-east-1')
client.create_table(

16
tests/test_dynamodb2/test_dynamodb_table_with_range_key.py
View file

@ -1765,6 +1765,14 @@ def test_boto3_update_table_gsi_throughput():
'AttributeName': 'subject',
'AttributeType': 'S'
},
{
'AttributeName': 'username',
'AttributeType': 'S'
},
{
'AttributeName': 'created',
'AttributeType': 'S'
}
],
ProvisionedThroughput={
'ReadCapacityUnits': 5,
@ -1939,6 +1947,14 @@ def test_update_table_gsi_throughput():
'AttributeName': 'subject',
'AttributeType': 'S'
},
{
'AttributeName': 'username',
'AttributeType': 'S'
},
{
'AttributeName': 'created',
'AttributeType': 'S'
}
],
ProvisionedThroughput={
'ReadCapacityUnits': 5,