catalin/moto
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Improve parsing of string values that represents booleans during block device mapping construction (#3073)

Browse source 
* convert str into bool

* Fix python2

* Fix python2

* pylint
This commit is contained in:
Maxim Kirilov 2020-06-16 08:03:02 +03:00 • committed by GitHub
commit 610bf36f3b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 44 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

30
tests/test_ec2/test_instances.py
View file

@ -128,7 +128,35 @@ def test_instance_terminate_discard_volumes():
@mock_ec2
def test_instance_terminate_keep_volumes():
def test_instance_terminate_keep_volumes_explicit():
ec2_resource = boto3.resource("ec2", "us-west-1")
result = ec2_resource.create_instances(
ImageId="ami-d3adb33f",
MinCount=1,
MaxCount=1,
BlockDeviceMappings=[
{
"DeviceName": "/dev/sda1",
"Ebs": {"VolumeSize": 50, "DeleteOnTermination": False},
}
],
)
instance = result[0]
instance_volume_ids = []
for volume in instance.volumes.all():
instance_volume_ids.append(volume.volume_id)
instance.terminate()
instance.wait_until_terminated()
assert len(list(ec2_resource.volumes.all())) == 1
@mock_ec2
def test_instance_terminate_keep_volumes_implicit():
ec2_resource = boto3.resource("ec2", "us-west-1")
result = ec2_resource.create_instances(