catalin/moto
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

#1054 - DynamoDB - Improve error handling for put_item without keys

Browse source
This commit is contained in:
Bert Blommers 2020-03-10 13:25:40 +00:00
commit 6ba00d9ad1
3 changed files with 26 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

7
moto/dynamodb2/models.py
View file

@ -792,6 +792,12 @@ class Table(BaseModel):
expression_attribute_values=None,
overwrite=False,
):
if self.hash_key_attr not in item_attrs.keys():
raise ValueError(
"One or more parameter values were invalid: Missing the key "
+ self.hash_key_attr
+ " in the item"
)
hash_value = DynamoType(item_attrs.get(self.hash_key_attr))
if self.has_range_key:
range_value = DynamoType(item_attrs.get(self.range_key_attr))
@ -808,7 +814,6 @@ class Table(BaseModel):
else:
lookup_range_value = DynamoType(expected_range_value)
current = self.get_item(hash_value, lookup_range_value)
item = Item(
hash_value, self.hash_key_type, range_value, self.range_key_type, item_attrs
)