catalin/moto
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Add tag_resource and untag_resource for ECS services

Browse source 
* Refactor resource ARN parsing
This commit is contained in:
Jim Shields 2019-10-03 15:16:07 -04:00
commit 6cb1173719
3 changed files with 235 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

175
tests/test_ecs/test_ecs_boto3.py
View file

@ -2411,3 +2411,178 @@ def test_list_tags_for_resource_unknown_service():
client.list_tags_for_resource(resourceArn=service_arn)
except ClientError as err:
err.response['Error']['Code'].should.equal('ServiceNotFoundException')
@mock_ecs
def test_ecs_service_tag_resource():
client = boto3.client('ecs', region_name='us-east-1')
_ = client.create_cluster(
clusterName='test_ecs_cluster'
)
_ = client.register_task_definition(
family='test_ecs_task',
containerDefinitions=[
{
'name': 'hello_world',
'image': 'docker/hello-world:latest',
'cpu': 1024,
'memory': 400,
'essential': True,
'environment': [{
'name': 'AWS_ACCESS_KEY_ID',
'value': 'SOME_ACCESS_KEY'
}],
'logConfiguration': {'logDriver': 'json-file'}
}
]
)
response = client.create_service(
cluster='test_ecs_cluster',
serviceName='test_ecs_service',
taskDefinition='test_ecs_task',
desiredCount=2
)
client.tag_resource(
resourceArn=response['service']['serviceArn'],
tags=[
{'key': 'createdBy', 'value': 'moto-unittest'},
{'key': 'foo', 'value': 'bar'},
]
)
response = client.list_tags_for_resource(resourceArn=response['service']['serviceArn'])
type(response['tags']).should.be(list)
response['tags'].should.equal([
{'key': 'createdBy', 'value': 'moto-unittest'},
{'key': 'foo', 'value': 'bar'},
])
@mock_ecs
def test_ecs_service_tag_resource_overwrites_tag():
client = boto3.client('ecs', region_name='us-east-1')
_ = client.create_cluster(
clusterName='test_ecs_cluster'
)
_ = client.register_task_definition(
family='test_ecs_task',
containerDefinitions=[
{
'name': 'hello_world',
'image': 'docker/hello-world:latest',
'cpu': 1024,
'memory': 400,
'essential': True,
'environment': [{
'name': 'AWS_ACCESS_KEY_ID',
'value': 'SOME_ACCESS_KEY'
}],
'logConfiguration': {'logDriver': 'json-file'}
}
]
)
response = client.create_service(
cluster='test_ecs_cluster',
serviceName='test_ecs_service',
taskDefinition='test_ecs_task',
desiredCount=2,
tags=[
{'key': 'foo', 'value': 'bar'},
]
)
client.tag_resource(
resourceArn=response['service']['serviceArn'],
tags=[
{'key': 'createdBy', 'value': 'moto-unittest'},
{'key': 'foo', 'value': 'hello world'},
]
)
response = client.list_tags_for_resource(resourceArn=response['service']['serviceArn'])
type(response['tags']).should.be(list)
response['tags'].should.equal([
{'key': 'createdBy', 'value': 'moto-unittest'},
{'key': 'foo', 'value': 'hello world'},
])
@mock_ecs
def test_ecs_service_untag_resource():
client = boto3.client('ecs', region_name='us-east-1')
_ = client.create_cluster(
clusterName='test_ecs_cluster'
)
_ = client.register_task_definition(
family='test_ecs_task',
containerDefinitions=[
{
'name': 'hello_world',
'image': 'docker/hello-world:latest',
'cpu': 1024,
'memory': 400,
'essential': True,
'environment': [{
'name': 'AWS_ACCESS_KEY_ID',
'value': 'SOME_ACCESS_KEY'
}],
'logConfiguration': {'logDriver': 'json-file'}
}
]
)
response = client.create_service(
cluster='test_ecs_cluster',
serviceName='test_ecs_service',
taskDefinition='test_ecs_task',
desiredCount=2,
tags=[
{'key': 'foo', 'value': 'bar'},
]
)
client.untag_resource(
resourceArn=response['service']['serviceArn'],
tagKeys=['foo']
)
response = client.list_tags_for_resource(resourceArn=response['service']['serviceArn'])
response['tags'].should.equal([])
@mock_ecs
def test_ecs_service_untag_resource_multiple_tags():
client = boto3.client('ecs', region_name='us-east-1')
_ = client.create_cluster(
clusterName='test_ecs_cluster'
)
_ = client.register_task_definition(
family='test_ecs_task',
containerDefinitions=[
{
'name': 'hello_world',
'image': 'docker/hello-world:latest',
'cpu': 1024,
'memory': 400,
'essential': True,
'environment': [{
'name': 'AWS_ACCESS_KEY_ID',
'value': 'SOME_ACCESS_KEY'
}],
'logConfiguration': {'logDriver': 'json-file'}
}
]
)
response = client.create_service(
cluster='test_ecs_cluster',
serviceName='test_ecs_service',
taskDefinition='test_ecs_task',
desiredCount=2,
tags=[
{'key': 'foo', 'value': 'bar'},
{'key': 'createdBy', 'value': 'moto-unittest'},
{'key': 'hello', 'value': 'world'},
]
)
client.untag_resource(
resourceArn=response['service']['serviceArn'],
tagKeys=['foo', 'createdBy']
)
response = client.list_tags_for_resource(resourceArn=response['service']['serviceArn'])
response['tags'].should.equal([
{'key': 'hello', 'value': 'world'},
])