catalin/moto
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

SSM parameters in cloudformation (AWS::SSM::Parameter::) are not recognized and resolved for default values (#4042)

Browse source 
* Add ssm parsing support for cloudformation stacks
This commit is contained in:
Sahil Shah 2021-06-29 13:28:52 -04:00 • committed by GitHub
commit 70a7a7e0a0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 36 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

34
moto/cloudformation/parsing.py
View file

@ -504,11 +504,26 @@ class ResourceMap(collections_abc.Mapping):
key = s3_backend.get_object(bucket_name, name)
self._parsed_resources.update(json.loads(key.value))
def parse_ssm_parameter(self, value, value_type):
# The Value in SSM parameters is the SSM parameter path
# we need to use ssm_backend to retreive the
# actual value from parameter store
parameter = ssm_backends[self._region_name].get_parameter(value, False)
actual_value = parameter.value
if value_type.find("List") > 0:
return actual_value.split(",")
return actual_value
def load_parameters(self):
parameter_slots = self._template.get("Parameters", {})
for parameter_name, parameter in parameter_slots.items():
# Set the default values.
self.resolved_parameters[parameter_name] = parameter.get("Default")
value = parameter.get("Default")
value_type = parameter.get("Type")
if value_type.startswith("AWS::SSM::Parameter::") and value:
value = self.parse_ssm_parameter(value, value_type)
self.resolved_parameters[parameter_name] = value
# Set any input parameters that were passed
self.no_echo_parameter_keys = []
@ -517,23 +532,8 @@ class ResourceMap(collections_abc.Mapping):
parameter_slot = parameter_slots[key]
value_type = parameter_slot.get("Type", "String")
def _parse_ssm_parameter(value, value_type):
# The Value in SSM parameters is the SSM parameter path
# we need to use ssm_backend to retreive the
# actual value from parameter store
parameter = ssm_backends[self._region_name].get_parameter(
value, False
)
actual_value = parameter.value
if value_type.find("List") > 0:
return actual_value.split(",")
return actual_value
if value_type.startswith("AWS::SSM::Parameter::"):
value = _parse_ssm_parameter(value, value_type)
value = self.parse_ssm_parameter(value, value_type)
if value_type == "CommaDelimitedList" or value_type.startswith("List"):
value = value.split(",")