From 896f7b6eb2c3ab70e66ac281b52859841851ab47 Mon Sep 17 00:00:00 2001
From: acsbendi <acsbendi28@gmail.com>
Date: Sun, 30 Jun 2019 16:36:49 +0200
Subject: [PATCH] Added more tests.

---
 tests/test_iam/test_iam_policies.py | 93 +++++++++++++++++++++++++++++
 1 file changed, 93 insertions(+)

diff --git a/tests/test_iam/test_iam_policies.py b/tests/test_iam/test_iam_policies.py
index 5a70bb9f..0c224c6b 100644
--- a/tests/test_iam/test_iam_policies.py
+++ b/tests/test_iam/test_iam_policies.py
@@ -54,6 +54,13 @@ def test_create_policy_with_invalid_policy_documents():
             },
             "error_message": 'An error occurred (MalformedPolicyDocument) when calling the CreatePolicy operation: Syntax errors in policy.'
         },
+        {
+            "document": {
+                "Version": "2012-10-17",
+                "Statement": ["afd"]
+            },
+            "error_message": 'An error occurred (MalformedPolicyDocument) when calling the CreatePolicy operation: Syntax errors in policy.'
+        },
         {
             "document": {
                 "Version": "2012-10-17",
@@ -135,6 +142,17 @@ def test_create_policy_with_invalid_policy_documents():
             },
             "error_message": 'An error occurred (MalformedPolicyDocument) when calling the CreatePolicy operation: Resource invalid resource must be in ARN format or "*".'
         },
+        {
+            "document": {
+                "Version": "2012-10-17",
+                "Statement": {
+                    "Effect": "Allow",
+                    "Action": "s3:ListBucket",
+                    "Resource": ["adf"]
+                }
+            },
+            "error_message": 'An error occurred (MalformedPolicyDocument) when calling the CreatePolicy operation: Resource adf must be in ARN format or "*".'
+        },
         {
             "document": {
                 "Version": "2012-10-17",
@@ -152,6 +170,17 @@ def test_create_policy_with_invalid_policy_documents():
             },
             "error_message": 'An error occurred (MalformedPolicyDocument) when calling the CreatePolicy operation: Policy statement must contain resources.'
         },
+        {
+            "document": {
+                "Version": "2012-10-17",
+                "Statement": {
+                    "Effect": "Allow",
+                    "Action": "s3:ListBucket",
+                    "Resource": []
+                }
+            },
+            "error_message": 'An error occurred (MalformedPolicyDocument) when calling the CreatePolicy operation: Policy statement must contain resources.'
+        },
         {
             "document": {
                 "Version": "2012-10-17",
@@ -247,6 +276,17 @@ def test_create_policy_with_invalid_policy_documents():
             },
             "error_message": 'An error occurred (MalformedPolicyDocument) when calling the CreatePolicy operation: Syntax errors in policy.'
         },
+        {
+            "document": {
+                "Version": "2012-10-17",
+                "Statement": {
+                    "Effect": "Deny",
+                    "Action": "s3:ListBucket",
+                    "Resource": ["adfdf", {}]
+                }
+            },
+            "error_message": 'An error occurred (MalformedPolicyDocument) when calling the CreatePolicy operation: Syntax errors in policy.'
+        },
         {
             "document": {
                 "Version": "2012-10-17",
@@ -453,6 +493,59 @@ def test_create_policy_with_invalid_policy_documents():
                 }
             },
             "error_message": 'An error occurred (MalformedPolicyDocument) when calling the CreatePolicy operation: Syntax errors in policy.'
+        },
+        {
+            "document": {
+                "Version": "2012-10-17",
+                "Statement": {
+                    "Effect": "denY",
+                    "Action": "s3:ListBucket",
+                    "Resource": "arn:aws:s3:::example_bucket"
+                }
+            },
+            "error_message": 'An error occurred (MalformedPolicyDocument) when calling the CreatePolicy operation: The policy failed legacy parsing'
+        },
+        {
+            "document": {
+                "Version": "2012-10-17",
+                "Statement":
+                    {
+                        "Effect": "Allow",
+                        "Action": "s3:ListBucket",
+                        "Resource": "arn:aws:s3:::example_bucket",
+                        "Condition": {
+                            "DateGreaterThan": {"a": "sdfdsf"}
+                        }
+                    }
+            },
+            "error_message": 'An error occurred (MalformedPolicyDocument) when calling the CreatePolicy operation: The policy failed legacy parsing'
+        },
+        {
+            "document": {
+                "Statement":
+                    {
+                        "Effect": "Allow",
+                        "Action": "s3:ListBucket",
+                        "Resource": "arn:aws:s3:::example_bucket",
+                        "Condition": {
+                            "DateGreaterThan": {"a": "sdfdsf"}
+                        }
+                    }
+            },
+            "error_message": 'An error occurred (MalformedPolicyDocument) when calling the CreatePolicy operation: Policy document must be version 2012-10-17 or greater.'
+        },
+        {
+            "document": {
+                "Version": "2012-10-17",
+                "Statement":
+                    {
+                        "Effect": "Allow",
+                        "Condition": {
+                            "DateGreaterThan": {"a": "sdfdsf"}
+                        }
+                    }
+            },
+            "error_message": 'An error occurred (MalformedPolicyDocument) when calling the CreatePolicy operation: The policy failed legacy parsing'
         }
     ]  # TODO add more tests