catalin/moto
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Cfn change set fix outputs (#3033)

Browse source 
* set creation time of the change set

* fix status, execution status, stak id, creation time and update tests
This commit is contained in:
Jeremie Tharaud 2020-05-29 08:33:24 +02:00 • committed by GitHub
commit 8fa625c3de
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 13 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

6
moto/cloudformation/models.py
View file

@ -240,7 +240,8 @@ class FakeStack(BaseModel):
self.resource_map = self._create_resource_map()
self.output_map = self._create_output_map()
if create_change_set:
self.status = "REVIEW_IN_PROGRESS"
self.status = "CREATE_COMPLETE"
self.execution_status = "AVAILABLE"
else:
self.create_resources()
self._add_stack_event("CREATE_COMPLETE")
@ -397,6 +398,7 @@ class FakeChangeSet(FakeStack):
self.change_set_id = change_set_id
self.change_set_name = change_set_name
self.changes = self.diff(template=template, parameters=parameters)
self.creation_time = datetime.utcnow()
def diff(self, template, parameters=None):
self.template = template
@ -587,7 +589,7 @@ class CloudFormationBackend(BaseBackend):
if stack is None:
raise ValidationError(stack_name)
else:
stack_id = generate_stack_id(stack_name)
stack_id = generate_stack_id(stack_name, region_name)
stack_template = template
change_set_id = generate_changeset_id(change_set_name, region_name)

2
moto/cloudformation/responses.py
View file

@ -609,7 +609,7 @@ DESCRIBE_CHANGE_SET_RESPONSE_TEMPLATE = """<DescribeChangeSetResponse>
</member>
{% endfor %}
</Parameters>
<CreationTime>2011-05-23T15:47:44Z</CreationTime>
<CreationTime>{{ change_set.creation_time_iso_8601 }}</CreationTime>
<ExecutionStatus>{{ change_set.execution_status }}</ExecutionStatus>
<Status>{{ change_set.status }}</Status>
<StatusReason>{{ change_set.status_reason }}</StatusReason>