catalin/moto
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Cfn change set fix outputs (#3033)

Browse source 
* set creation time of the change set

* fix status, execution status, stak id, creation time and update tests
This commit is contained in:
Jeremie Tharaud 2020-05-29 08:33:24 +02:00 • committed by GitHub
commit 8fa625c3de
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 13 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

11
tests/test_cloudformation/test_cloudformation_stack_crud_boto3.py
View file

@ -819,7 +819,7 @@ def test_create_change_set_from_s3_url():
in response["Id"]
)
assert (
"arn:aws:cloudformation:us-east-1:123456789:stack/NewStack"
"arn:aws:cloudformation:us-west-1:123456789:stack/NewStack"
in response["StackId"]
)
@ -838,7 +838,12 @@ def test_describe_change_set():
stack["ChangeSetName"].should.equal("NewChangeSet")
stack["StackName"].should.equal("NewStack")
stack["Status"].should.equal("REVIEW_IN_PROGRESS")
stack["Status"].should.equal("CREATE_COMPLETE")
stack["ExecutionStatus"].should.equal("AVAILABLE")
two_secs_ago = datetime.now(tz=pytz.UTC) - timedelta(seconds=2)
assert (
two_secs_ago < stack["CreationTime"] < datetime.now(tz=pytz.UTC)
), "Change set should have been created recently"
cf_conn.create_change_set(
StackName="NewStack",
@ -868,7 +873,7 @@ def test_execute_change_set_w_arn():
)
ec2.describe_instances()["Reservations"].should.have.length_of(0)
cf_conn.describe_change_set(ChangeSetName="NewChangeSet")["Status"].should.equal(
"REVIEW_IN_PROGRESS"
"CREATE_COMPLETE"
)
# Execute change set
cf_conn.execute_change_set(ChangeSetName=change_set["Id"])