catalin/moto
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Delete ECR image when it has no tags

Browse source 
This is a bug fix to my initial work when implementing
batch_delete_image. Deleting the last tag for a given image should
delete the image from the backend.

I also cleaned up the tests previously-added in the initial
implementation.
This commit is contained in:
Juan Martinez 2019-06-17 13:41:35 -04:00
commit 9a26c92e72
2 changed files with 59 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

5
moto/ecr/models.py
View file

@ -403,7 +403,10 @@ class ECRBackend(BaseBackend):
image_found = True
repository.images[num].image_tag = image_id["imageTag"]
response["imageIds"].append(image.response_batch_delete_image)
repository.images[num].remove_tag(image_id["imageTag"])
if len(image.image_tags) > 1:
repository.images[num].remove_tag(image_id["imageTag"])
else:
repository.images.remove(image)
if not image_found:
failure_response = {