catalin/moto
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Throw exception if same security group rule added twice. Closes #737.

Browse source
This commit is contained in:
Steve Pulec 2017-01-11 22:35:27 -05:00
commit a292150087
2 changed files with 34 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

13
moto/ec2/models.py
View file

@ -1255,6 +1255,15 @@ class SecurityGroup(TaggedEC2Resource):
return self.id
raise UnformattedGetAttTemplateException()
def add_ingress_rule(self, rule):
if rule in self.ingress_rules:
raise InvalidParameterValueError('security_group')
else:
self.ingress_rules.append(rule)
def add_egress_rule(self, rule):
self.egress_rules.append(rule)
class SecurityGroupBackend(object):
@ -1367,7 +1376,7 @@ class SecurityGroupBackend(object):
source_groups.append(source_group)
security_rule = SecurityRule(ip_protocol, from_port, to_port, ip_ranges, source_groups)
group.ingress_rules.append(security_rule)
group.add_ingress_rule(security_rule)
def revoke_security_group_ingress(self,
group_name_or_id,
@ -1432,7 +1441,7 @@ class SecurityGroupBackend(object):
source_groups.append(source_group)
security_rule = SecurityRule(ip_protocol, from_port, to_port, ip_ranges, source_groups)
group.egress_rules.append(security_rule)
group.add_egress_rule(security_rule)
def revoke_security_group_egress(self,
group_name_or_id,