catalin/moto
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Add missing Fn::GetAtt attributes to S3 bucket mock (#3396)

Browse source 
* Add missing `Fn::GetAtt` attributes to S3 bucket mock

Addresses an issue reported here https://github.com/localstack/aws-cdk-local/issues/1

* Reformat touched files with `black`

* Reformat touched files with `black` on Python 3.7
This commit is contained in:
Neal Granger 2020-10-27 09:04:32 -07:00 • committed by GitHub
commit a5fc14b5bc
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 69 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

43
tests/test_s3/test_s3_cloudformation.py
View file

@ -148,8 +148,9 @@ def test_s3_bucket_cloudformation_update_replacement():
@mock_s3
@mock_cloudformation
def test_s3_bucket_cloudformation_outputs():
s3 = boto3.client("s3", region_name="us-east-1")
cf = boto3.resource("cloudformation", region_name="us-east-1")
region_name = "us-east-1"
s3 = boto3.client("s3", region_name=region_name)
cf = boto3.resource("cloudformation", region_name=region_name)
stack_name = "test-stack"
bucket_name = "test-bucket"
template = {
@ -165,6 +166,26 @@ def test_s3_bucket_cloudformation_outputs():
"Value": {"Fn::GetAtt": ["TestBucket", "Arn"]},
"Export": {"Name": {"Fn::Sub": "${AWS::StackName}:BucketARN"}},
},
"BucketDomainName": {
"Value": {"Fn::GetAtt": ["TestBucket", "DomainName"]},
"Export": {"Name": {"Fn::Sub": "${AWS::StackName}:BucketDomainName"}},
},
"BucketDualStackDomainName": {
"Value": {"Fn::GetAtt": ["TestBucket", "DualStackDomainName"]},
"Export": {
"Name": {"Fn::Sub": "${AWS::StackName}:BucketDualStackDomainName"}
},
},
"BucketRegionalDomainName": {
"Value": {"Fn::GetAtt": ["TestBucket", "RegionalDomainName"]},
"Export": {
"Name": {"Fn::Sub": "${AWS::StackName}:BucketRegionalDomainName"}
},
},
"BucketWebsiteURL": {
"Value": {"Fn::GetAtt": ["TestBucket", "WebsiteURL"]},
"Export": {"Name": {"Fn::Sub": "${AWS::StackName}:BucketWebsiteURL"}},
},
"BucketName": {
"Value": {"Ref": "TestBucket"},
"Export": {"Name": {"Fn::Sub": "${AWS::StackName}:BucketName"}},
@ -176,4 +197,22 @@ def test_s3_bucket_cloudformation_outputs():
output = {item["OutputKey"]: item["OutputValue"] for item in outputs_list}
s3.head_bucket(Bucket=output["BucketName"])
output["BucketARN"].should.match("arn:aws:s3.+{bucket}".format(bucket=bucket_name))
output["BucketDomainName"].should.equal(
"{bucket}.s3.amazonaws.com".format(bucket=bucket_name)
)
output["BucketDualStackDomainName"].should.equal(
"{bucket}.s3.dualstack.{region}.amazonaws.com".format(
bucket=bucket_name, region=region_name
)
)
output["BucketRegionalDomainName"].should.equal(
"{bucket}.s3.{region}.amazonaws.com".format(
bucket=bucket_name, region=region_name
)
)
output["BucketWebsiteURL"].should.equal(
"http://{bucket}.s3-website.{region}.amazonaws.com".format(
bucket=bucket_name, region=region_name
)
)
output["BucketName"].should.equal(bucket_name)