catalin/moto
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Minor RDS Clean up (#3682)

Browse source 
* Fix `DBInstanceNotFound` error message

Changed from `Database` to `DBInstance`, which is actually what comes back from AWS.

* Remove duplicate test

The removed test actually fails if run in isolation because `rds2` is not a
valid boto3 client service.  The reason this test never caused CI to fail is
because it is redefined later in the test suite, effectively making it dead
code that will never run.

Duplicate test has been removed and the remaining test has been improved
with more explicit asserts.
This commit is contained in:
Brian Pandola 2021-02-13 03:12:02 -08:00 • committed by GitHub
commit ae2865d559
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 11 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

3
moto/rds2/exceptions.py
View file

@ -24,7 +24,8 @@ class RDSClientError(BadRequest):
class DBInstanceNotFoundError(RDSClientError):
def __init__(self, database_identifier):
super(DBInstanceNotFoundError, self).__init__(
"DBInstanceNotFound", "Database {0} not found.".format(database_identifier)
"DBInstanceNotFound",
"DBInstance {0} not found.".format(database_identifier),
)