catalin/moto
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

fix: deleting non-existent topic shouldn't raise KeyError (#3285)

Browse source
This commit is contained in:
Daniel Okey-Okoro 2020-09-10 00:32:41 -07:00 • committed by GitHub
commit c321ad46b0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 19 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

6
tests/test_sns/test_topics.py
View file

@ -32,6 +32,12 @@ def test_create_and_delete_topic():
topics.should.have.length_of(0)
@mock_sns_deprecated
def test_delete_non_existent_topic():
conn = boto.connect_sns()
conn.delete_topic.when.called_with("a-fake-arn").should.throw(BotoServerError)
@mock_sns_deprecated
def test_get_missing_topic():
conn = boto.connect_sns()

9
tests/test_sns/test_topics_boto3.py
View file

@ -35,6 +35,15 @@ def test_create_and_delete_topic():
topics.should.have.length_of(0)
@mock_sns
def test_delete_non_existent_topic():
conn = boto3.client("sns", region_name="us-east-1")
conn.delete_topic.when.called_with(
TopicArn="arn:aws:sns:us-east-1:123456789012:fake-topic"
).should.throw(conn.exceptions.NotFoundException)
@mock_sns
def test_create_topic_with_attributes():
conn = boto3.client("sns", region_name="us-east-1")