catalin/moto
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Remove redundant test code (#3640)

Browse source 
These tests, when run, do not execute any `moto` code. They fail the
parameter validation check in `botocore`, which raises an exception
before ever sending a request.  These tests do not cover or verify
any `moto` behavior and have been removed.
This commit is contained in:
Brian Pandola 2021-01-31 04:21:24 -08:00 • committed by GitHub
commit cd044ef00b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
9 changed files with 18 additions and 199 deletions
Download patch file Download diff file Expand all files Collapse all files

2
tests/test_ec2/test_flow_logs.py
View file

@ -4,7 +4,7 @@ import pytest
import boto3
from botocore.exceptions import ParamValidationError, ClientError
from botocore.exceptions import ClientError
from botocore.parsers import ResponseParserError
import json
import sure # noqa

7
tests/test_ec2/test_subnets.py
View file

@ -10,7 +10,7 @@ import boto.vpc
import pytest
import sure # noqa
from boto.exception import EC2ResponseError
from botocore.exceptions import ClientError, ParamValidationError
from botocore.exceptions import ClientError
from moto import mock_ec2, mock_ec2_deprecated
from tests import EXAMPLE_AMI_ID
@ -202,11 +202,6 @@ def test_modify_subnet_attribute_validation():
VpcId=vpc.id, CidrBlock="10.0.0.0/24", AvailabilityZone="us-west-1a"
)
with pytest.raises(ParamValidationError):
client.modify_subnet_attribute(
SubnetId=subnet.id, MapPublicIpOnLaunch={"Value": "invalid"}
)
@mock_ec2_deprecated
def test_subnet_get_by_id():