catalin/moto
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

#2710 - S3 - Raise specific error when GetObject is called with unknown VersionId (#3532)

Browse source
This commit is contained in:
Bert Blommers 2021-01-13 16:06:09 +00:00 • committed by GitHub
commit d1696a37e5
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 41 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

19
tests/test_s3/test_s3.py
View file

@ -4939,6 +4939,25 @@ def test_request_partial_content_should_contain_actual_content_length():
e.response["Error"]["RangeRequested"].should.equal(requested_range)
@mock_s3
def test_get_unknown_version_should_throw_specific_error():
bucket_name = "my_bucket"
object_key = "hello.txt"
s3 = boto3.resource("s3", region_name="us-east-1")
client = boto3.client("s3", region_name="us-east-1")
bucket = s3.create_bucket(Bucket=bucket_name)
bucket.Versioning().enable()
content = "some text"
s3.Object(bucket_name, object_key).put(Body=content)
with pytest.raises(ClientError) as e:
client.get_object(Bucket=bucket_name, Key=object_key, VersionId="unknown")
e.value.response["Error"]["Code"].should.equal("InvalidArgument")
e.value.response["Error"]["Message"].should.equal("Invalid version id specified")
e.value.response["Error"]["ArgumentName"].should.equal("versionId")
e.value.response["Error"]["ArgumentValue"].should.equal("unknown")
@mock_s3
def test_request_partial_content_without_specifying_range_should_return_full_object():
bucket = "bucket"