catalin/moto
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Merge pull request #1986 from okomestudio/ts/fix-s3-common-prefix-pagination

Browse source 
Activate proper pagination for S3 common prefixes
This commit is contained in:
Steve Pulec 2018-12-28 21:22:07 -05:00 • committed by GitHub
commit dec665be43
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 35 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

24
tests/test_s3/test_s3.py
View file

@ -1172,6 +1172,30 @@ def test_boto3_list_keys_xml_escaped():
assert 'Owner' not in resp['Contents'][0]
@mock_s3
def test_boto3_list_objects_v2_common_prefix_pagination():
s3 = boto3.client('s3', region_name='us-east-1')
s3.create_bucket(Bucket='mybucket')
max_keys = 1
keys = ['test/{i}/{i}'.format(i=i) for i in range(3)]
for key in keys:
s3.put_object(Bucket='mybucket', Key=key, Body=b'v')
prefixes = []
args = {"Bucket": 'mybucket', "Delimiter": "/", "Prefix": "test/", "MaxKeys": max_keys}
resp = {"IsTruncated": True}
while resp.get("IsTruncated", False):
if "NextContinuationToken" in resp:
args["ContinuationToken"] = resp["NextContinuationToken"]
resp = s3.list_objects_v2(**args)
if "CommonPrefixes" in resp:
assert len(resp["CommonPrefixes"]) == max_keys
prefixes.extend(i["Prefix"] for i in resp["CommonPrefixes"])
assert prefixes == [k[:k.rindex('/') + 1] for k in keys]
@mock_s3
def test_boto3_list_objects_v2_truncated_response():
s3 = boto3.client('s3', region_name='us-east-1')