Commit graph

62 commits

Author SHA1 Message Date
Modhaffer Rahmani
8fe5a680a5
Added explicit exception raise when no stack found. (#3559)
* Added explicit exception raise when no stack found.

Currently, any operation that uses 'get_stack' method from 'CloudFormationBackend' class
will fail with AttributeError or jinja2 exception if ran against non-existing stack(created/deleted)
To fix the issue I explicitly raised a 'ValidationError' exception.
Added tests for boto and boto3 responses.

* Moved non-existing stack tests to 'test_stack_events'

When using 'update_stack' to test raising an exception when the stack doesn't exist
test coverage dropped by 0.5%. I am using stack_events instead.

* Removed some unreachable paths

After adding the exception couple of paths in the code are unreachable as 'get_stack' doesn't return 'None' anymore.
This is the reason why coverall was reporting decreased coverage.

* Removed an unreachable path I missed

* Added couple of tests in cloudformation/models

* Added more assertions around raised exception

* Formatted document using black to fix issue with travis.
2021-01-16 14:42:51 +00:00
usmangani1
c5de56ce70
Fix: CloudFormation support status filter in list stacks (#3115)
* Fix: CloudFormation support status filter in list stacks

* Added test for non decorator

Co-authored-by: usmankb <usman@krazybee.com>
2020-07-12 13:39:42 +01:00
Shane Dowling
6305f707d2
fix to capture yaml scanner error (#3077) 2020-06-18 09:50:58 +01:00
Jeremie Tharaud
90e200f0f6
Add missing changes when creating a change set (#3039)
* Display changes when creating a change set

* add change set id and description when describing stack

* fix lint with flake8 and black
2020-06-03 06:08:35 +01:00
Jeremie Tharaud
8fa625c3de
Cfn change set fix outputs (#3033)
* set creation time of the change set

* fix status, execution status, stak id, creation time and update tests
2020-05-29 07:33:24 +01:00
Bert Blommers
04f488da62 #2388 - CloudFormation - CreateChangeSet does not create resources, as per spec 2020-03-24 10:22:08 +00:00
Bert Blommers
3fab3f572f #2773 - CloudFormation - Set CreationDate 2020-03-17 16:09:42 +00:00
Brandon Bradley
800e5ab7d2 requested changes from review 2020-02-01 14:52:48 -06:00
Brandon Bradley
c877266f86 fix 500 error on non-existing stack name 2020-01-29 16:27:56 -06:00
gruebel
9d9b620878 Fixed linter errors 2019-12-26 21:03:49 +01:00
gruebel
d7ba355a65 Add missing regions to all services 2019-12-26 17:12:22 +01:00
Asher Foa
96e5b1993d Run black on moto & test directories. 2019-10-31 10:36:05 -07:00
Steve Pulec
88e1f0fa23
Merge pull request #2015 from corrjo/master
#1514 Stackset Support
2019-04-22 19:04:47 -05:00
Mike Grima
921b5a3227 Fixing broken tests #2126
- KMS
- S3
- CloudFormation (Thanks kgutwin!)
2019-03-28 10:09:03 -07:00
John Corrales
a6f7f06c30
Merge branch 'master' into master 2019-02-11 17:51:18 -08:00
Mark Challoner
337601b5fb
Add CloudFormation methods delete_change_set, describe_change_set and list_change_sets. 2019-01-21 17:18:50 +00:00
John Corrales
0ab5edc962 return delete_instance operation 2019-01-15 07:20:13 -08:00
John Corrales
5fb43ee7b6
Operations (#4)
Added stop, list operation results, and describe operation
2019-01-14 22:01:53 -08:00
John Corrales
4207a8e182
Add stacksets (#3)
Added most stack set responses
2019-01-10 21:33:15 -08:00
Steve Pulec
5d172d9c97
Merge pull request #1969 from grahamlyons/list-deleted-cloudformation-stacks
Return the deleted stacks in the list stacks call
2018-12-28 21:07:06 -05:00
grahamlyons
2d554cd098
Return the deleted stacks in the list stacks call
This matches the behaviour of the AWS API.
2018-11-26 23:58:41 +00:00
adam davis
b66965e6e8 Adding cloudformation-validate. Cfn-lint does the heavy lifting. 2018-11-05 15:16:32 -08:00
Theodore Wong
da8bd545bf Fixed CF creation to trap imports of non-existent values 2018-05-30 11:59:25 -07:00
Joe Keegan
bb4bc01999 update self.template_dict based on new template 2017-12-21 12:10:27 -08:00
NimbusScale
21606bc8ae update support JSON or YAML 2017-12-18 20:44:04 -08:00
Alex M
e75f3ef4d4 Implement execute change set endpoint (#1391) 2017-12-14 12:07:23 +00:00
Alex M
2346e14e00 Add create change set endpoint (#1389) 2017-12-11 09:23:35 +00:00
Toshiya Kawasaki
2f6f42a183 handle short form function in cfn yaml template (#1103) 2017-09-07 11:28:15 -07:00
Jessie Nadler
f5106f2cc8 Add Fn::ImportValue support 2017-06-08 18:34:09 -04:00
Jessie Nadler
9d37992c64 Make all_exports subscriptable 2017-06-02 17:17:22 -04:00
Jessie Nadler
87752457a3 Remove useless list comprehension 2017-06-02 16:57:16 -04:00
Jessie Nadler
c6603c6248 Validate export names are unique 2017-06-02 16:35:19 -04:00
Jessie Nadler
de9ea10eb1 Add list_exports to CloudFormationResponse 2017-06-02 16:31:46 -04:00
Jessie Nadler
a0651ccde5 Add exports to CloudFormationBackend 2017-06-02 16:18:52 -04:00
Steve Pulec
0fe824277b Merge pull request #923 from JackDanger/jack/cloud-formation-yaml
Allow yaml templates for cloud formation
2017-05-12 18:41:46 -04:00
Jack Danger Canty
9801d22629 The name of yaml exceptions is more consistent between Py2->3 2017-05-11 07:15:07 -07:00
Steve Pulec
0adebeed24 Merge #913. 2017-05-10 21:58:42 -04:00
Jack Danger Canty
bf3fff6e2c Allow yaml templates for cloud formation
Fixes #912
2017-05-01 11:28:35 -07:00
Andrew Garrett
6f4cb512ac Allow CloudFormation stack tags to be updated
Limitations:

* does not update the tags of the resources in the stack. that can be
implemented later.
* does not support the supposed feature of clearing tags by passing an
empty value that boto3 mentions in its documentation. I could not find
anything in the request body to indicate when an empty value was passed.
2017-03-17 23:57:57 +00:00
Steve Pulec
6d422d1f37 Add BaseModel to all models. 2017-03-11 23:41:12 -05:00
Steve Pulec
3b4ef2cf15 Merge in master. 2017-03-05 09:58:39 -05:00
Andrew Garrett
e7735c3ee1 Add event IDs to CF Stack events (#852)
So that events can be uniquely identified.

I tried to match the format documented here:
http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/using-cfn-listing-event-history.html
2017-03-04 23:12:55 -05:00
David Wilcox
a9554924df make cloudformation update stack use parameters provided (#843) 2017-03-04 22:48:51 -05:00
Steve Pulec
f37bad0e00 Lints. 2017-02-23 21:37:43 -05:00
Jesse Szwedko
e1260bca06 cloudformation: Support RoleARN for create and update stack (#807)
Signed-off-by: Andrew Harris <andrew.harris@getbraintree.com>
2017-01-18 22:59:47 -05:00
Andrew Garrett
542248158f Implement the meat for DescribeStackEvents
Right now this just adds events for the stack itself via the lifecycle
methods of the FakeStack object, but it is possible to add other kinds
of events (I left a method for that should someone need inspiration
later.)
2016-06-29 21:56:39 +00:00
Steve Pulec
a600deb96a Fix merge conflicts and add EC2 Instance delete. Closes #576. 2016-04-28 09:22:31 -04:00
Lawrence Aiello
3017181862 Fixes issue #575: cloudformation update_stack response ResponseParserError. 2016-04-18 14:37:12 -04:00
Lars Fronius
519b8e59aa Propagate stack-level tags to resources
According to
http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-resource-tags.html
"All stack-level tags, including automatically created tags, are
propagated to resources that AWS CloudFormation supports. Currently,
tags are not propagated to Amazon EBS volumes that are created from
block device mappings."
2016-03-15 15:36:02 +01:00
Andrew Garrett
39d9fbcd02 Added resource deletion upon stack deletion
Only implemented for ASGs and LCs since they're all we cared about for
our particular problem. It should be easy to follow this pattern for
other resource types, though.

Signed-off-by: Scott Greene <scott.greene@getbraintree.com>
2016-02-29 19:50:29 +00:00