This commit puts AST validation on the execution path. This means updates get validated prior to being executed. There were quite a few tests that were not working against Amazon DDB. These tests I considered broken and as such this commit adapts them such that they pass against Amazon DDB. test_update_item_on_map() => One of the SET actions would try to set a nested element by specifying the nesting on the path rather than by putting a map as a value for a non-existent key. This got changed. test_item_size_is_under_400KB => Used the keyword "item" which DDB doesn't like. Change to cont in order to keep the same sizings. => Secondly the size error messages differs a bit depending whether it is part of the update or part of a put_item. For an update it should be: Item size to update has exceeded the maximum allowed size otherwise it is Item size has exceeded the maximum allowed size' test_remove_top_level_attribute => Used a keyword item. Use ExpressionAttributeNames test_update_item_double_nested_remove => Used keywords name & first. Migrated to non-deprecated API and use ExpressionAttributeNames test_update_item_set & test_boto3_update_item_conditions_pass & test_boto3_update_item_conditions_pass_because_expect_not_exists & test_boto3_update_item_conditions_pass_because_expect_not_exists_by_compare_to_null & test_boto3_update_item_conditions_pass_because_expect_exists_by_compare_to_not_null & test_boto3_update_item_conditions_fail & test_boto3_update_item_conditions_fail_because_expect_not_exists & test_boto3_update_item_conditions_fail_because_expect_not_exists_by_compare_to_null => Were broken tests which had string literal instead of value placeholder
133 lines
4.5 KiB
Python
133 lines
4.5 KiB
Python
class InvalidIndexNameError(ValueError):
|
|
pass
|
|
|
|
|
|
class MockValidationException(ValueError):
|
|
def __init__(self, message):
|
|
self.exception_msg = message
|
|
|
|
|
|
class InvalidUpdateExpressionInvalidDocumentPath(MockValidationException):
|
|
invalid_update_expression_msg = (
|
|
"The document path provided in the update expression is invalid for update"
|
|
)
|
|
|
|
def __init__(self):
|
|
super(InvalidUpdateExpressionInvalidDocumentPath, self).__init__(
|
|
self.invalid_update_expression_msg
|
|
)
|
|
|
|
|
|
class InvalidUpdateExpression(MockValidationException):
|
|
invalid_update_expr_msg = "Invalid UpdateExpression: {update_expression_error}"
|
|
|
|
def __init__(self, update_expression_error):
|
|
self.update_expression_error = update_expression_error
|
|
super(InvalidUpdateExpression, self).__init__(
|
|
self.invalid_update_expr_msg.format(
|
|
update_expression_error=update_expression_error
|
|
)
|
|
)
|
|
|
|
|
|
class AttributeDoesNotExist(MockValidationException):
|
|
attr_does_not_exist_msg = (
|
|
"The provided expression refers to an attribute that does not exist in the item"
|
|
)
|
|
|
|
def __init__(self):
|
|
super(AttributeDoesNotExist, self).__init__(self.attr_does_not_exist_msg)
|
|
|
|
|
|
class ExpressionAttributeNameNotDefined(InvalidUpdateExpression):
|
|
name_not_defined_msg = "An expression attribute name used in the document path is not defined; attribute name: {n}"
|
|
|
|
def __init__(self, attribute_name):
|
|
self.not_defined_attribute_name = attribute_name
|
|
super(ExpressionAttributeNameNotDefined, self).__init__(
|
|
self.name_not_defined_msg.format(n=attribute_name)
|
|
)
|
|
|
|
|
|
class AttributeIsReservedKeyword(InvalidUpdateExpression):
|
|
attribute_is_keyword_msg = (
|
|
"Attribute name is a reserved keyword; reserved keyword: {keyword}"
|
|
)
|
|
|
|
def __init__(self, keyword):
|
|
self.keyword = keyword
|
|
super(AttributeIsReservedKeyword, self).__init__(
|
|
self.attribute_is_keyword_msg.format(keyword=keyword)
|
|
)
|
|
|
|
|
|
class ExpressionAttributeValueNotDefined(InvalidUpdateExpression):
|
|
attr_value_not_defined_msg = "An expression attribute value used in expression is not defined; attribute value: {attribute_value}"
|
|
|
|
def __init__(self, attribute_value):
|
|
self.attribute_value = attribute_value
|
|
super(ExpressionAttributeValueNotDefined, self).__init__(
|
|
self.attr_value_not_defined_msg.format(attribute_value=attribute_value)
|
|
)
|
|
|
|
|
|
class UpdateExprSyntaxError(InvalidUpdateExpression):
|
|
update_expr_syntax_error_msg = "Syntax error; {error_detail}"
|
|
|
|
def __init__(self, error_detail):
|
|
self.error_detail = error_detail
|
|
super(UpdateExprSyntaxError, self).__init__(
|
|
self.update_expr_syntax_error_msg.format(error_detail=error_detail)
|
|
)
|
|
|
|
|
|
class InvalidTokenException(UpdateExprSyntaxError):
|
|
token_detail_msg = 'token: "{token}", near: "{near}"'
|
|
|
|
def __init__(self, token, near):
|
|
self.token = token
|
|
self.near = near
|
|
super(InvalidTokenException, self).__init__(
|
|
self.token_detail_msg.format(token=token, near=near)
|
|
)
|
|
|
|
|
|
class InvalidExpressionAttributeNameKey(MockValidationException):
|
|
invalid_expr_attr_name_msg = (
|
|
'ExpressionAttributeNames contains invalid key: Syntax error; key: "{key}"'
|
|
)
|
|
|
|
def __init__(self, key):
|
|
self.key = key
|
|
super(InvalidExpressionAttributeNameKey, self).__init__(
|
|
self.invalid_expr_attr_name_msg.format(key=key)
|
|
)
|
|
|
|
|
|
class ItemSizeTooLarge(MockValidationException):
|
|
item_size_too_large_msg = "Item size has exceeded the maximum allowed size"
|
|
|
|
def __init__(self):
|
|
super(ItemSizeTooLarge, self).__init__(self.item_size_too_large_msg)
|
|
|
|
|
|
class ItemSizeToUpdateTooLarge(MockValidationException):
|
|
item_size_to_update_too_large_msg = (
|
|
"Item size to update has exceeded the maximum allowed size"
|
|
)
|
|
|
|
def __init__(self):
|
|
super(ItemSizeToUpdateTooLarge, self).__init__(
|
|
self.item_size_to_update_too_large_msg
|
|
)
|
|
|
|
|
|
class IncorrectOperandType(InvalidUpdateExpression):
|
|
inv_operand_msg = "Incorrect operand type for operator or function; operator or function: {f}, operand type: {t}"
|
|
|
|
def __init__(self, operator_or_function, operand_type):
|
|
self.operator_or_function = operator_or_function
|
|
self.operand_type = operand_type
|
|
super(IncorrectOperandType, self).__init__(
|
|
self.inv_operand_msg.format(f=operator_or_function, t=operand_type)
|
|
)
|